Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace usages of executor_name fixture with user/admin fixture #2205

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Feb 13, 2025

Some uses remain where I wasn't sure, plus alerts because those got reworked anyway.

Closes #2159

Some uses remain where I wasn't sure, plus alerts because those got reworked anyway.

Closes #2159
Copy link

API Changelog 4.17.2.dev26+gf779f8f3

Copy link

codecov bot commented Feb 13, 2025

Bundle Report

Bundle size has no change ✅

@zusorio zusorio changed the title chore: Replace usages of executor_name fixture with users/admin fixture chore: Replace usages of executor_name fixture with user/admin fixture Feb 13, 2025
Copy link

This report was generated by comparing f779f8f with c211b6b.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 464
change 0
new 0
delete 0

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.54%. Comparing base (c211b6b) to head (54fdb1c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2205   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files         239      239           
  Lines        8198     8198           
  Branches      568      568           
=======================================
  Hits         7177     7177           
  Misses        861      861           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 merged commit 1602959 into main Feb 14, 2025
34 checks passed
@MoritzWeber0 MoritzWeber0 deleted the replace-executor-name branch February 14, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace executor_name fixture with user and admin fixtures
2 participants