fix(monitoring): Tolerate unavailable data sources #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus can become unavailable due to updates, restarts, etc. Since we don't consider it as essential component, this is normal behaviour. No longer send alerts if Prometheus is not reachable.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 239 239
Lines 8212 8212
Branches 569 569
=======================================
Hits 7191 7191
Misses 861 861
Partials 160 160 ☔ View full report in Codecov by Sentry. |
Bundle ReportBundle size has no change ✅ |
zusorio
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus can become unavailable due to updates, restarts, etc. Since we don't consider it as essential component, this is normal behaviour. No longer send alerts if Prometheus is not reachable.