Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include Grafana time range in feedback emails #2218

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

MoritzWeber0
Copy link
Member

The dashboard will use the creation date of the session as from timestamp and the time where the email is sent as to timestamp.

The dashboard will use the creation date of the session as from timestamp
and the time where the email is sent as to timestamp.
@MoritzWeber0 MoritzWeber0 requested a review from zusorio February 18, 2025 11:46
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (ce67ae4) to head (820c059).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2218   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         240      240           
  Lines        8267     8268    +1     
  Branches      568      568           
=======================================
+ Hits         7244     7245    +1     
  Misses        863      863           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Feb 18, 2025

Bundle Report

Bundle size has no change ✅

Copy link

API Changelog 4.18.2.dev4+gb0a5ba2b

Copy link

This report was generated by comparing b0a5ba2 with ce67ae4.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 484
change 0
new 0
delete 0

Copy link
Member

@zusorio zusorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would also be very useful for these links to be on the session overview table but that can be a separate PR

@MoritzWeber0
Copy link
Member Author

I think it would also be very useful for these links to be on the session overview table but that can be a separate PR

Yes, that's out of scope for this PR.

@MoritzWeber0 MoritzWeber0 merged commit aa7817b into main Feb 18, 2025
34 checks passed
@MoritzWeber0 MoritzWeber0 deleted the adjust-grafana-time-range branch February 18, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants