Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Collect logs per session individually #2225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MoritzWeber0
Copy link
Member

Logs are collected from /var/log/session instead of the custom paths. This enabled better separation between logs for specific sessions. Also enables support for logs in read-only sessions.

Requires DSD-DBS/capella-dockerimages#386 for continuous log collection.

Copy link

codecov bot commented Feb 20, 2025

Bundle Report

Bundle size has no change ✅

Copy link

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

Copy link

github-actions bot commented Feb 20, 2025

API Changelog 4.18.2.dev9+gf4cce811

GET /api/v1/projects/{project_slug}/models

  • ⚠️ removed the required property '/items/tool/config/monitoring/logging/path' from the response with the '200' status

POST /api/v1/projects/{project_slug}/models

  • ⚠️ removed the required property 'tool/config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/projects/{project_slug}/models/{model_slug}

  • ⚠️ removed the required property 'tool/config/monitoring/logging/path' from the response with the '200' status

PATCH /api/v1/projects/{project_slug}/models/{model_slug}

  • ⚠️ removed the required property 'tool/config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/projects/{project_slug}/models/{model_slug}/provisioning

  • ⚠️ removed the required property '/anyOf[subschema 1: ModelProvisioning]/session/anyOf[subschema 1: Session]/version/tool/config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/projects/{project_slug}/tools

  • ⚠️ removed the required property '/items/tool/config/monitoring/logging/path' from the response with the '200' status

POST /api/v1/projects/{project_slug}/tools

  • ⚠️ removed the required property 'tool/config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/sessions

  • ⚠️ removed the required property '/items/version/tool/config/monitoring/logging/path' from the response with the '200' status

POST /api/v1/sessions

  • ⚠️ removed the required property 'version/tool/config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/sessions/{session_id}

  • ⚠️ removed the required property 'version/tool/config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/tools

  • ⚠️ removed the required property '/items/config/monitoring/logging/path' from the response with the '200' status

POST /api/v1/tools

  • ⚠️ removed the required property 'config/monitoring/logging/path' from the response with the '200' status
  • ⚠️ removed the request property 'config/monitoring/logging/path'

GET /api/v1/tools/*/versions

  • ⚠️ removed the required property '/items/tool/config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/tools/default

  • ⚠️ removed the required property 'config/monitoring/logging/path' from the response with the '200' status

GET /api/v1/tools/{tool_id}

  • ⚠️ removed the required property 'config/monitoring/logging/path' from the response with the '200' status

PUT /api/v1/tools/{tool_id}

  • ⚠️ removed the required property 'config/monitoring/logging/path' from the response with the '200' status
  • ⚠️ removed the request property 'config/monitoring/logging/path'

GET /api/v1/users/{user_id}/sessions

  • ⚠️ removed the required property '/items/version/tool/config/monitoring/logging/path' from the response with the '200' status

This comment has been minimized.

Copy link

github-actions bot commented Feb 20, 2025

A Storybook preview is available for commit f4cce81.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

Logs are collected from `/var/log/session` instead of the custom paths.
This enabled better separation between logs for specific sessions.
Also enables support for logs in read-only sessions.

Signed-off-by: MoritzWeber <[email protected]>
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (d86b97b) to head (add7cda).

Files with missing lines Patch % Lines
...kend/capellacollab/sessions/hooks/log_collector.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           bump-grafana-loki    #2225      +/-   ##
=====================================================
+ Coverage              87.62%   87.64%   +0.01%     
=====================================================
  Files                    240      240              
  Lines                   8268     8269       +1     
  Branches                 568      567       -1     
=====================================================
+ Hits                    7245     7247       +2     
+ Misses                   863      862       -1     
  Partials                 160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This report was generated by comparing f4cce81 with d86b97b.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 484
change 0
new 0
delete 0

Base automatically changed from bump-grafana-loki to main February 21, 2025 08:23
@MoritzWeber0 MoritzWeber0 requested a review from zusorio February 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant