Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable fullscreen when leaving session viewer #2229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MoritzWeber0
Copy link
Member

Thanks to @micha91 for reporting.

@MoritzWeber0 MoritzWeber0 requested a review from zusorio February 21, 2025 13:07
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (aedb237) to head (45b9f19).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2229   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files         240      240           
  Lines        8285     8285           
  Branches      571      571           
=======================================
  Hits         7262     7262           
  Misses        863      863           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Feb 21, 2025

Bundle Report

Changes will increase total bundle size by 91 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
capella-collab-manager-esm 13.93MB 91 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: capella-collab-manager-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 91 bytes 2.74MB 0.0%

Files in assets/index-*.js:

  • ./src/app/sessions/service/fullscreen.service.ts → Total Size: 737 bytes

  • ./src/app/sessions/session/session-viewer.component.ts → Total Size: 5.26kB

Copy link

A Storybook preview is available for commit cb5dbd5.
➡️ View Storybook
➡️ View Chromatic build

Copy link

This report was generated by comparing cb5dbd5 with aedb237.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 484
change 0
new 0
delete 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant