Modified Suleiman-Ritchie soil evaporation #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 10, 2025 10:37
- also needs to re-implement UPFLOW (cherry picked from commit 27ab129)
chporter
requested review from
GerritHoogenboom,
bkimball,
aymansuleiman and
fabiooliveira72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified as per Ayman Suleiman at Jan 2025 DSSAT sprint.
-- ES occurs from top 15 cm only. Re-instate UPFLOW.
-- Uses MESEV = "M" (for Modified Suleiman-Ritchie)
This runs for all DSSAT experiments and treatments. Soil evaporation is considerably lower than all other methods. I ran the default soil evaporation in each FileX vs R, S, and M method override using external simulation control file.
Average ratio over all experiments / treatments
0.98393 | Ritchie : default
1.183594 | Suleiman-Ritchie : default
0.716105 | Modified Suleiman-Ritchie : default
0.62579 | Modified Suleiman-Ritchie : Suleiman-Ritchie
This needs to be thoroughly vetted by Ayman, Gerrit, Fabio, Bruce before accepting the pull request.