Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement client side transition visibility #258

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Implement client side transition visibility #258

merged 5 commits into from
Aug 4, 2023

Conversation

alecpm
Copy link
Contributor

@alecpm alecpm commented Aug 4, 2023 •
edited
Loading

This implements transition (and consumable) visibility per #234 and #241.

It also fixes a bug when displaying transitions involving null objects.

@alecpm alecpm self-assigned this Aug 4, 2023
@alecpm alecpm requested a review from jessesnyder August 4, 2023 21:01
@alecpm alecpm changed the base branch from master to one-hour-one-life August 4, 2023 21:01
@alecpm alecpm force-pushed the issues/256-transition-visibility branch from 98bccce to 1ad38b0 Compare August 4, 2023 22:00
@alecpm alecpm force-pushed the issues/256-transition-visibility branch from 1ad38b0 to dbfee86 Compare August 4, 2023 22:19
jessesnyder
jessesnyder approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@jessesnyder jessesnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great. I may have found a small mistake with the representation of an unseen transition target, and a couple other var name things.

dlgr/griduniverse/static/scripts/demo.js Show resolved Hide resolved
dlgr/griduniverse/static/scripts/demo.js Outdated Show resolved Hide resolved
dlgr/griduniverse/static/scripts/demo.js Outdated Show resolved Hide resolved
dlgr/griduniverse/static/scripts/demo.js Outdated Show resolved Hide resolved
dlgr/griduniverse/static/scripts/demo.js Outdated Show resolved Hide resolved
@alecpm
Copy link
Contributor Author

alecpm commented Aug 4, 2023

Comments should all be addressed now.

@alecpm alecpm merged commit 0e05a3a into one-hour-one-life Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesnyder jessesnyder jessesnyder approved these changes

Assignees

@alecpm alecpm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecpm @jessesnyder