Close #79 - Filtering on date fields within Hardware Lifecycle view #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the code for filtering hardware lifecycles on dates before user-defined end of sale, end of maintenance, end of security and/or end of support dates
copacomilan
changed the title
copacomilan
changed the title
copacomilan
changed the title
|
Quick check here - the forms\filtersets.py change is showing the same 4 datefield definitions (end_of_sale__lt). Was this meant to be the four different Fieldsets configured earlier? |
For every DateField filter in forms/filtersets.py end_of_sale__lt was used as I copied and pasted it over from a local install, this is now fixed
auto-merge was automatically disabled
February 10, 2025 12:38
Head branch was pushed to by a user without write access
Yes indeed, thank you for noticing that, I had to copy the code from my local install and forgot to change the fields to their individual names. It is fixed now. |
Forgot to change the labels with the duplicate field fix commit. That is fixed now too.
|
And that obviously goes for the labels for these filter fields as well, luckily I did notice that mistake myself upon review. Everything should be in order now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #79 - Add filtering on date fields for Hardware Lifecycle view
This commit adds the code for filtering hardware lifecycles on dates before user-defined end of sale, end of maintenance, end of security and/or end of support dates