Add a macro for namespace #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drisspg
commented
Jan 7, 2025
drisspg
commented
Jan 7, 2025
drisspg
force-pushed
the
macro-level-namespace
branch
10 times, most recently
from
7fbf9d9 to
2629591
Compare
drisspg
commented
Jan 10, 2025
drisspg
force-pushed
the
macro-level-namespace
branch
from
2629591 to
3dfecdd
Compare
LucasWilkinson
pushed a commit
to vllm-project/flash-attention
that referenced
this pull request
Jan 16, 2025
drisspg
added a commit
to pytorch/pytorch
that referenced
this pull request
Jan 17, 2025
…ation into 3rd party submod" # Summary ### Sticky points Cuda-graph rng handling has changed / deviated from original implementation. We will be left with a dangling 'offset' val and confusing naming due to BC ## Dependencies - Flash PR: Dao-AILab/flash-attention#1419 ### Other Points - The BC linter is complaining about losing generate.py and its functions which is not real BC surface cc albanD [ghstack-poisoned]
drisspg
added a commit
to pytorch/pytorch
that referenced
this pull request
Jan 17, 2025
…arty submod" # Summary ### Sticky points Cuda-graph rng handling has changed / deviated from original implementation. We will be left with a dangling 'offset' val and confusing naming due to BC ## Dependencies - Flash PR: Dao-AILab/flash-attention#1419 ### Other Points - The BC linter is complaining about losing generate.py and its functions which is not real BC surface cc albanD [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Working changes to see what is needed to change flash's packaging in PyTorch