-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mtl dgpu #62
Conversation
1d0f69c
to
3105fdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ADC can be configured for 0 - AVCC range with ADCIVMFSCS1. It doesn't have to be in range of 0 - AVCC/1.1
src/board/novacustom/v540tnx/gpio.c
Outdated
GCR15 = BIT(4); | ||
// Set GPB5 and GPD2 to 1.8V | ||
GCR19 = BIT(7) | BIT(0); | ||
// Set GPD3 to 1.8V, GPF2 and GPF3 to 3.3V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schematics says GPF2 and GPF3 is 1.8V
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPF3 thankfully goes to U56 which accepts 1.2 ~ 5V, but yeah this probably needs to be fixed.
The GPIO voltage settings do not seem to cover all GPIOs annotated as 1.8V in schematics. List of GPIO that are marked 1.8V on schematics:
GPIO set to 1.8V by the code (according to comments):
So there is a lot of GPIOs with incorrect voltage probably:
Same comments apply to both dGPU variants |
Are we goign to fix those 1.8V pins as in my above comment? @mkopec |
We are, I just need to review the schematics again to confirm these 100%. Do note that this config was dumped from Clevo firmware so it's probably not going to cause overvoltage issues outright. It's also possible the schematics are wrong... |
I just did that for you in the above comment. Again, if you lower the voltage of the pins from 3.3V to 1.8V it won't cause overvoltage, maybe undervoltage... I also have been checking what the signals are used for and what their voltage should be. |
a69d160
to
8728cc7
Compare
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
It's been observed that polling GN21 too often results in throttling. Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
15% is too much and impacts performance Signed-off-by: Michał Kopeć <[email protected]>
… voltage Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
These power limits work on CPU only, but the GPU is the major power consumer on these boards. Applying Psys power limits only results in CPU being stuck at 400MHz while GPU is doing anything. Signed-off-by: Michał Kopeć <[email protected]>
No description provided.