UIE-204 Narrow Ajax Usage pt24 (final)

[msilva-broad]

• narrow Ajax() usage within last of src/libs/ajax area modules to call Ajax().SubAreaX directly.
• demoted Ajax() to no longer be exported from ajax.ts. It is now called AjaxTestingRoot and only a setupAjaxTestUtil method is exposed.
• setupAjaxTestUtil is called from appLoader.js since it is no longer incedentally initalized through ajax.ts module load.
• unit tests added for setupAjaxTestUtil.
• improve mock types where possible

Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]

Summary of changes:

What

• Ajax() super-object has been an anti-pattern of sorts, that has been pervasive and problematic in our code base. It's caused many lost hours to circular dependency trouble-shooting, and overly-entwined dependency footprint in general. Previous investments carefully unraveled the circular dependencies, but with Ajax() super-object still kicking around, they could easily be re-introduced.
• The Ajax() super-object facilitated data-call unification and bespoke data-call override mechanics that facilitated script-like test setup convenience for some of our end2end tests to perform workspace, runitme, etc preconditions through direct data calls before the main test scenario. This seemed more valuable when end2end tests were the only real automated testing footprint for Terra UI. But we have now invested in a growing set of unit tests, which provide great coverage, speed, and other benefits over end2end tests. So we have been reducing the number and complexity of end2end tests, making the Ajax() testing root pattern something we should probably discourage. It is kept for current compatibility, but would be nice to one day simplify out it's need in the remaining end2end tests that still use it.
• This series of PRs has also taken the opportunity to optimize type safety in many of our unit tests. Lack of type safety on mock signatures is a nasty gap, since it would leave us blind to contract drift. Tests would continue to pass even though their mocks no longer reflect reality. This has been addressed in all tests that were mocking Ajax() subareas.
• Ajax mocking was also clunky since tests has to mock the outer and inner function/contract layers. This has also been cleaned up.

Why

• improve code maintainability, improve modularity and potential code sharing by simplifying dependency graph.

Testing strategy

[kevinmarete]

Some minor comments but looks good to me!

[kevinmarete]

Suggested change

	import { WorkspaceData } from 'src/libs/ajax/WorkspaceDataService';
	import { Capabilities, Capability } from 'src/libs/ajax/WorkspaceDataService';
	import { Capabilities, Capability, WorkspaceData } from 'src/libs/ajax/WorkspaceDataService';

You are importing WorkspaceDataService multiple times, recommend just adding WorkspaceData to the existing import.

[msilva-broad]

fixed

[kevinmarete]

Suggested change

	import { GoogleStorage } from 'src/libs/ajax/GoogleStorage';
	import { GCSItem } from 'src/libs/ajax/GoogleStorage';
	import { GCSItem, GoogleStorage } from 'src/libs/ajax/GoogleStorage';

Multiple imports, consider importing once.

[msilva-broad]

fixed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[LizBaldo]

LGTM, thanks for doing this!