Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mongoose plugin tests #5217

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Fix mongoose plugin tests #5217

merged 9 commits into from
Feb 10, 2025

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Feb 6, 2025

What does this PR do?

  • move withPeerService out of before block
  • remove extra done() call
  • change peer.service tag value. The test author set 'db' as the value but after fixing the test i checked 'peer.service' tag is set as the collection name used in the test.
  • ensure mongo is connected setting bufferCommands: false and waiting

Motivation

I believe the part of the test calling withPeerService was not entirely correct.
As done() was called by spanGenerationFn function

(done) => {
  const PeerCat = mongoose.model('PeerCat', { name: String })
  new PeerCat({ name: 'PeerCat' }).save().catch(done)
  done()
}

the test ended before 'peer.service' and '_dd.peer.service.source' expects were checked

expect(span.meta).to.have.property('peer.service', typeof service === 'function' ? service() : service)
expect(span.meta).to.have.property('_dd.peer.service.source', serviceSource)

so this part of the test has never worked as it should.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Feb 6, 2025

Overall package size

Self size: 8.63 MB
Deduped: 95.03 MB
No deduping: 95.55 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (66c13fc) to head (2f2479e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5217   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         482      482           
  Lines       21527    21527           
=======================================
  Hits        17473    17473           
  Misses       4054     4054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 6, 2025

Datadog Report

Branch report: igor/fix-mongoose-8.10.0
Commit report: 0529733
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 630 Passed, 0 Skipped, 16m 13.13s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-06 12:05:03

Comparing candidate commit 607bb95 in PR branch igor/fix-mongoose-8.10.0 with baseline commit f49e6ff in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 899 metrics, 32 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟥 max_rss_usage [+77.817MB; +82.603MB] or [+6.552%; +6.955%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-79.666MB; -71.438MB] or [-8.448%; -7.576%]

@iunanua iunanua force-pushed the igor/fix-mongoose-8.10.0 branch from f090e9a to a4dee82 Compare February 6, 2025 11:49
@iunanua iunanua marked this pull request as ready for review February 10, 2025 11:12
@iunanua iunanua requested review from a team as code owners February 10, 2025 11:12
@iunanua iunanua merged commit ca855f8 into master Feb 10, 2025
350 of 352 checks passed
@iunanua iunanua deleted the igor/fix-mongoose-8.10.0 branch February 10, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants