ESLint: Require 'use strict' header

[watson]

What does this PR do?

Motivation

Plugin Checklist

• Unit tests.
• TypeScript definitions.
• TypeScript tests.
• API documentation.
• CircleCI jobs/workflows.
• Plugin is exported.

Additional Notes

[watson]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• ESLint: Require 'use strict' header #5218 👈 (View in Graphite)
• Enable recommended rules for eslint-plugin-n #5216
• Upgrade ESLint from v8 to v9 #5215
• Clean up ESLint config #5214
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Overall package size

Self size: 8.64 MB
Deduped: 95.05 MB
No deduping: 95.56 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.7.1 | 96.67 kB | 96.67 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (b29b51c) to head (7921f14).

Additional details and impacted files

@@                        Coverage Diff                        @@
##           watson/enable-eslint-plugin-n    #5218      +/-   ##
=================================================================
- Coverage                          81.16%   77.23%   -3.94%     
=================================================================
  Files                                482      473       -9     
  Lines                              21527    21372     -155     
=================================================================
- Hits                               17473    16506     -967     
- Misses                              4054     4866     +812     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datadog-datadog-prod-us1]

Datadog Report

Branch report: watson/strict
Commit report: a5418da
Test service: dd-trace-js-integration-tests

❌ 14 Failed (0 Known Flaky), 539 Passed, 0 Skipped, 8m 29.54s Total Time

❌ Failed Tests (14)

This report shows up to 5 failed tests.

• cucumber@latest commonJS reporting via agentless dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/cucumber/cucumber.spec.js - Details

  Expand for error

   expected 6 to equal 4
  

• cucumber@latest commonJS reporting via agentless dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/cucumber/cucumber.spec.js - Details

  Expand for error

   expected 6 to equal 4
  

• jest CommonJS intelligent test runner does not skip suites if suite is marked as unskippable - integration-tests/jest/jest.spec.js - Details

  Expand for error

   expected { '_dd.p.dm': '-0', …(45) } to have property 'test.itr.forced_run'
  

• jest CommonJS intelligent test runner does not skip suites if suite is marked as unskippable - integration-tests/jest/jest.spec.js - Details

  Expand for error

   expected { '_dd.p.dm': '-0', …(45) } to have property 'test.itr.forced_run'
  

• jest CommonJS intelligent test runner only sets forced to run if suite was going to be skipped by ITR - integration-tests/jest/jest.spec.js - Details

  Expand for error

   expected { '_dd.p.dm': '-0', …(45) } to have property 'test.itr.unskippable'
  

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-02-06 12:16:04

Comparing candidate commit 55331e5 in PR branch watson/strict with baseline commit c0412e5 in branch watson/enable-eslint-plugin-n.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 905 metrics, 26 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

• 🟩 max_rss_usage [-113.834MB; -65.170MB] or [-11.870%; -6.795%]

scenario:plugin-graphql-with-depth-on-max-18

• 🟩 max_rss_usage [-100.345MB; -50.883MB] or [-10.286%; -5.216%]

[simon-id]

Codewise LGTM, but some jobs are failing, including:

• lint is complaining that some requires point to nothing, but it's normal as that's part of our instrumentation test system
• some IAST tests failing that look like true positives, i'm pinging IAST people