lazy load telemetry entrypoint only when needed #5258
Conversation
Overall package sizeSelf size: 8.68 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5258 +/- ##
==========================================
+ Coverage 81.29% 83.13% +1.84%
==========================================
Files 481 475 -6
Lines 21598 20758 -840
==========================================
- Hits 17558 17258 -300
+ Misses 4040 3500 -540 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 630 Passed, 0 Skipped, 16m 9.49s Total Time |
BenchmarksBenchmark execution time: 2025-02-13 22:22:41 Comparing candidate commit 7cf2992 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 910 metrics, 21 unstable metrics. scenario:plugin-graphql-with-async-hooks-18
|
| 'grpc.client.error.statuses': 'DD_GRPC_CLIENT_ERROR_STATUSES', | ||
| 'grpc.server.error.statuses': 'DD_GRPC_SERVER_ERROR_STATUSES' | ||
| } | ||
| module.exports = { |
There was a problem hiding this comment.
you're mixing arrow and non arrow function ?
There was a problem hiding this comment.
i don't see any this so why not use only non-arrow functions ?
There was a problem hiding this comment.
I don't really see why they shouldn't be mixed (there are use cases where they must be mixed) but I can change it.
There was a problem hiding this comment.
Fixed, and I also did the same fix for #5254
rochdev
force-pushed
the
lazy-telemetry-root
branch
from
ed889cc to
7cf2992
Compare
What does this PR do?
Lazy load telemetry entrypoint only when needed.
Motivation
Right now when telemetry is disabled, the code is still loaded which impacts startup time.
Additional Notes
For now I only handled the entrypoint, but there are also modules using the internals directly which will be addressed in another PR.