Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move otel to datadog context conversion on otel side #5260

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Feb 12, 2025

What does this PR do?

Move OTel to Datadog context conversion on OTel side.

Motivation

OTel can be quite intrusive and heavy, so it's best kept isolated.

Copy link

github-actions bot commented Feb 12, 2025

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 81.24%. Comparing base (8e8898d) to head (9430ceb).

Files with missing lines Patch % Lines
packages/dd-trace/src/opentelemetry/tracer.js 8.69% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5260   +/-   ##
=======================================
  Coverage   81.24%   81.24%           
=======================================
  Files         487      487           
  Lines       21703    21704    +1     
=======================================
+ Hits        17633    17634    +1     
  Misses       4070     4070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 12, 2025

Datadog Report

Branch report: otel-to-dd-in-otel
Commit report: 987ff90
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 627 Passed, 0 Skipped, 11m 36.85s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 00:54:11

Comparing candidate commit fbf1fd0 in PR branch otel-to-dd-in-otel with baseline commit 8e8898d in branch master.

Found 21 performance improvements and 2 performance regressions! Performance is the same for 889 metrics, 21 unstable metrics.

scenario:appsec-control-22

  • 🟩 cpu_user_time [-20.607ms; -16.593ms] or [-6.739%; -5.427%]
  • 🟩 execution_time [-23.620ms; -19.432ms] or [-6.454%; -5.310%]
  • 🟩 instructions [-47.7M instructions; -46.4M instructions] or [-5.495%; -5.349%]

scenario:appsec-control-with-attacks-18

  • 🟩 cpu_user_time [-22.212ms; -18.123ms] or [-6.201%; -5.060%]

scenario:appsec-control-with-attacks-22

  • 🟩 cpu_user_time [-21.643ms; -17.634ms] or [-7.044%; -5.739%]
  • 🟩 execution_time [-23.157ms; -18.693ms] or [-6.299%; -5.085%]
  • 🟩 instructions [-47.6M instructions; -46.2M instructions] or [-5.441%; -5.281%]

scenario:log-skip-log-22

  • 🟩 execution_time [-18.982ms; -17.505ms] or [-5.458%; -5.033%]

scenario:log-with-debug-22

  • 🟩 execution_time [-19.912ms; -17.430ms] or [-5.740%; -5.024%]

scenario:log-with-error-22

  • 🟩 execution_time [-19.321ms; -18.308ms] or [-5.649%; -5.353%]

scenario:log-without-log-22

  • 🟩 execution_time [-19.692ms; -18.349ms] or [-6.072%; -5.658%]

scenario:net-with-tracer-18

  • 🟩 cpu_user_time [-33.634ms; -29.463ms] or [-8.958%; -7.847%]
  • 🟩 execution_time [-35.636ms; -33.657ms] or [-6.587%; -6.221%]

scenario:net-with-tracer-22

  • 🟩 instructions [-50.4M instructions; -47.3M instructions] or [-5.519%; -5.180%]

scenario:plugin-bluebird-with-tracer-18

  • 🟩 execution_time [-21.993ms; -19.039ms] or [-5.794%; -5.015%]

scenario:plugin-graphql-with-async-hooks-18

  • 🟥 execution_time [+248.777ms; +278.774ms] or [+5.114%; +5.731%]
  • 🟥 max_rss_usage [+89.125MB; +94.775MB] or [+16.825%; +17.892%]

scenario:plugin-graphql-with-async-hooks-20

  • 🟩 max_rss_usage [-118.424MB; -103.612MB] or [-18.456%; -16.148%]

scenario:spans-finish-later-22

  • 🟩 instructions [-244.0M instructions; -170.5M instructions] or [-8.537%; -5.967%]

scenario:startup-with-tracer-18

  • 🟩 cpu_user_time [-30.918ms; -24.470ms] or [-12.781%; -10.115%]
  • 🟩 execution_time [-29.617ms; -28.077ms] or [-10.562%; -10.013%]
  • 🟩 instructions [-45.5M instructions; -39.9M instructions] or [-7.029%; -6.168%]

scenario:startup-with-tracer-22

  • 🟩 instructions [-41.6M instructions; -38.9M instructions] or [-6.755%; -6.318%]

@rochdev rochdev marked this pull request as ready for review February 13, 2025 00:26
@rochdev rochdev requested a review from a team as a code owner February 13, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant