Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): only report configuration with known values #5262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmehala
Copy link

@dmehala dmehala commented Feb 13, 2025

What does this PR do?

This PR ensures that telemetry configuration is only reported when it has valid values. Since the value field is mandatory for configuration entries (as specified in the schema), reporting entries without values results in invalid payloads that our intake do not or entirely process.

Motivation

To reduce the number of invalid payloads and ensure the tracer conforms to the expected schema.

Plugin Checklist

I've done none of the thing below because I'm a clueless cpp engineer but feel free to take over.

Additional Notes

@dmehala dmehala requested a review from a team as a code owner February 13, 2025 12:15
@dmehala dmehala requested a review from ida613 February 13, 2025 12:16
Copy link

github-actions bot commented Feb 13, 2025

Overall package size

Self size: 8.68 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (8e8898d) to head (5aaa5b1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   81.24%   81.24%           
=======================================
  Files         487      487           
  Lines       21703    21705    +2     
=======================================
+ Hits        17633    17635    +2     
  Misses       4070     4070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 13, 2025

Datadog Report

Branch report: dmehala/telemetry/do-not-report-empty-value
Commit report: 44eac88
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 629 Passed, 0 Skipped, 15m 37.78s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-13 14:51:12

Comparing candidate commit 5aaa5b1 in PR branch dmehala/telemetry/do-not-report-empty-value with baseline commit 8e8898d in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 907 metrics, 24 unstable metrics.

scenario:plugin-graphql-with-async-hooks-18

  • 🟥 max_rss_usage [+86.072MB; +106.524MB] or [+16.271%; +20.137%]

scenario:plugin-graphql-with-async-hooks-22

  • 🟩 max_rss_usage [-138.696MB; -82.308MB] or [-21.276%; -12.626%]

@bm1549 bm1549 requested a review from simon-id February 14, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants