Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch system-tests back to main branch #4304

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 20, 2025

What does this PR do?
It switches system-tests ref back to main

Motivation:
I forgot to change the ref in this PR before merging

Change log entry
None.

Additional Notes:
This PR has to be merged first:
DataDog/system-tests#3843

How to test the change?
CI should be green.

@y9v y9v self-assigned this Jan 20, 2025
@y9v y9v requested a review from a team as a code owner January 20, 2025 17:13
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 20, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 20, 2025

Datadog Report

Branch report: switch-system-tests-back-to-main
Commit report: b629aee
Test service: dd-trace-rb

✅ 0 Failed, 22068 Passed, 1477 Skipped, 6m 16.17s Total Time
⌛ 3 Performance Regressions

⌛ Performance Regressions vs Default Branch (3)

  • Rails integration tests for an application with a basic route behaves like appsec standalone billing without upstream appsec propagation with attack and trace is kept with priority 2 from 0 sampling priority behaves like a trace with ASM Standalone tags is expected to eq 1212121212121212121 - rspec 4.45s (+3.86s, +649%) - Details
  • Rails integration tests for an application with a basic route behaves like appsec standalone billing without upstream appsec propagation with attack and trace is kept with priority 2 from -1 sampling priority behaves like a trace sent to agent with Datadog-Client-Computed-Stats header is expected to equal true - rspec 3.9s (+3.29s, +546%) - Details
  • Rails integration tests for an application with a basic route behaves like appsec standalone billing without upstream appsec propagation with attack and trace is kept with priority 2 from 0 sampling priority behaves like a request with propagated headers is expected to include "_dd.p.other=1" and "_dd.p.appsec=1" - rspec 4.24s (+3.64s, +607%) - Details

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-01-20 17:35:52

Comparing candidate commit b629aee in PR branch switch-system-tests-back-to-main with baseline commit b33b1d6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (b33b1d6) to head (b629aee).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4304      +/-   ##
==========================================
- Coverage   97.72%   97.70%   -0.02%     
==========================================
  Files        1359     1359              
  Lines       82480    82479       -1     
  Branches     4198     4198              
==========================================
- Hits        80605    80590      -15     
- Misses       1875     1889      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. I've spotted that DataDog/system-tests#3843 isn't yet merged so I'm tagging this as do-not-merge but once that's clear this one is good to go as well.

@ivoanjo ivoanjo added the do-not-merge/WIP Not ready for merge label Jan 21, 2025
@y9v y9v removed the do-not-merge/WIP Not ready for merge label Jan 21, 2025
@y9v y9v merged commit 4d51a86 into master Jan 21, 2025
383 of 384 checks passed
@y9v y9v deleted the switch-system-tests-back-to-main branch January 21, 2025 09:17
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants