-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported versions workflow #4326
Update supported versions workflow #4326
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-01-29 14:55:57 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 22115 Passed, 1476 Skipped, 5m 16.66s Total Time ⌛ Performance Regressions vs Default Branch (4)
|
BenchmarksBenchmark execution time: 2025-01-29 20:19:56 Comparing candidate commit 17db220 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4326 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 1368 1368
Lines 82999 82998 -1
Branches 4220 4220
==========================================
- Hits 81113 81107 -6
- Misses 1886 1891 +5 ☔ View full report in Codecov by Sentry. |
Looks great! |
Thank you! |
Would be nice to see the generated markdown in this PR but if it's a lot of work I approve this PR as is and will review the markdown in a later PR. |
@p-datadog Thanks! I saw that you approved it, but the PR with the generated markdown table is here: #4236 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me
I think we'd want to follow up with product (specifically with httpx
) and a follow up PR to add some tests for this.
What does this PR do?
Makes the following changes:
generate_table_versions.rb
script into thefind_gem_version_bounds.rb
scriptMotivation:
Addition to #4210
Change log entry
No.
Additional Notes:
How to test the change?
See the generated PR here: #4236