-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to requesting Prometheus format by default #15292
Revert to requesting Prometheus format by default #15292
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex for the extensive background work done to conclude on the revert till a long term solution is identified 👍
What does this PR do?
It reverts the default accept header to request
text/plain
(i.e. prometheus format) that was introduced by #14445.Motivation
It looks like the library support for OpenMetrics format generation and parsing is somewhat immature (e.g. prometheus/client_golang#829) which made setting the accept header to request the OpenMetrics format if available more disturbing than we anticipated.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.