Skip to content

Commit

Permalink
Incloud node name in preview change event
Browse files Browse the repository at this point in the history
Signed-off-by: Wei-Chun, Chang <[email protected]>
  • Loading branch information
wcchang1115 committed Dec 23, 2024
1 parent d634ebe commit 053d5b4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion js/src/components/lineage/NodeView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export function NodeView({ node, onCloseNode }: NodeViewProps) {
icon={<Icon as={findByRunType("preview_change")?.icon} />}
onClick={() => {
onPreviewChangeOpen();
trackPreviewChange({ action: "explore" });
trackPreviewChange({ action: "explore", node: node.name });
}}
>
Preview Change (Experiment)
Expand Down
2 changes: 1 addition & 1 deletion js/src/components/lineage/PreviewChangeView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function PreviewChangeTopBar({
onClick={() => {
onRunResultOpen();
runQuery();
trackPreviewChange({ action: "run" });
trackPreviewChange({ action: "run", node: current?.name });
}}
colorScheme="blue"
isLoading={isPending}
Expand Down
1 change: 1 addition & 0 deletions js/src/lib/api/track.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export function trackHistoryAction(props: HistoryActionProps) {

interface PreviewChangeProps {
action: "explore" | "run";
node?: string;
}

export function trackPreviewChange(props: PreviewChangeProps) {
Expand Down

0 comments on commit 053d5b4

Please sign in to comment.