Merge pull request #478 from DataRecce/feature/drc-768-query-page-rel…

…ayout [Refine] Implement Run Query button based on the UI design
DataRecce · Nov 11, 2024 · 0e8b89a · 0e8b89a
2 parents d123f44 + 00de696
commit 0e8b89a
Show file tree

Hide file tree

Showing 4 changed files with 302 additions and 141 deletions.
diff --git a/js/src/components/query/QueryForm.tsx b/js/src/components/query/QueryForm.tsx
@@ -1,4 +1,5 @@
 import { useLineageGraphContext } from "@/lib/hooks/LineageGraphContext";
+import { DropdownValuesInput } from "@/utils/DropdownValuesInput";
 import { InfoIcon } from "@chakra-ui/icons";
 import {
   Flex,
@@ -7,17 +8,7 @@ import {
   FormLabel,
   Tooltip,
 } from "@chakra-ui/react";
-import {
-  AutoComplete,
-  AutoCompleteCreatable,
-  AutoCompleteInput,
-  AutoCompleteItem,
-  AutoCompleteList,
-  AutoCompleteTag,
-  Item,
-  ItemTag,
-} from "@choc-ui/chakra-autocomplete";
-import { useMemo } from "react";
+import { useMemo, useRef, useState } from "react";
 
 interface QueryFormProps extends FlexProps {
   defaultPrimaryKeys: string[] | undefined;
@@ -30,13 +21,14 @@ export const QueryForm = ({
   ...prob
 }: QueryFormProps) => {
   const { lineageGraph } = useLineageGraphContext();
+  const labelInfo =
+    "Provide a primary key to perform query diff in data warehouse and only return changed rows.";
 
-  const columns = useMemo(() => {
+  const availableColumns = useMemo(() => {
     if (!lineageGraph) {
       return [];
     }
-
-    const columnSet = new Set();
+    const columnSet = new Set<string>();
     for (const modelName in lineageGraph.nodes) {
       const model = lineageGraph.nodes[modelName];
       const baseColumns = model.data.base?.columns;
@@ -53,57 +45,24 @@ export const QueryForm = ({
     return Array.from(columnSet).sort();
   }, [lineageGraph]);
 
-  const labelInfo =
-    "Provide a primary key to perform query diff in data warehouse and only return changed rows.";
-
   return (
     <Flex {...prob}>
       <FormControl m="4px 8px">
-        <FormLabel>
-          Primary key{" "}
+        <FormLabel fontSize={"8pt"} margin={"0"}>
+          Diff with Primary Key(s) (suggested){" "}
           <Tooltip label={labelInfo}>
             <InfoIcon color="gray.600" boxSize="3" />
           </Tooltip>
         </FormLabel>
-        <AutoComplete
-          restoreOnBlurIfEmpty={false}
-          multiple
-          creatable
-          filter={(query: string, optionValue: Item["value"]) => {
-            return optionValue.startsWith(query);
-          }}
-          onChange={(vals: string[]) => onPrimaryKeysChange(vals)}
-          defaultValues={
-            defaultPrimaryKeys !== undefined && defaultPrimaryKeys.length !== 0
-              ? defaultPrimaryKeys
-              : undefined
-          }
-        >
-          <AutoCompleteInput
-            placeholder="Select primary key..."
-            variant="outline"
-          >
-            {({ tags }: { tags: ItemTag[] }) =>
-              tags.map((tag, tid) => (
-                <AutoCompleteTag
-                  key={tid}
-                  label={tag.label}
-                  onRemove={tag.onRemove}
-                />
-              ))
-            }
-          </AutoCompleteInput>
-          <AutoCompleteList>
-            {columns.map((column, cid) => (
-              <AutoCompleteItem key={`option-${cid}`} value={column}>
-                {column}
-              </AutoCompleteItem>
-            ))}
-            <AutoCompleteCreatable>
-              {({ value }) => <Flex>Add &apos;{value}&apos; to List</Flex>}
-            </AutoCompleteCreatable>
-          </AutoCompleteList>
-        </AutoComplete>
+        <DropdownValuesInput
+          unitName="key"
+          defaultValues={defaultPrimaryKeys}
+          suggestionList={availableColumns}
+          onValuesChange={onPrimaryKeysChange}
+          size="xs"
+          width={"240px"}
+          placeholder="Start by typing key name..."
+        />
       </FormControl>
     </Flex>
   );

diff --git a/js/src/components/query/QueryPage.tsx b/js/src/components/query/QueryPage.tsx
@@ -122,63 +122,61 @@ export const QueryPage = () => {
   });
 
   return (
-    <HSplit
-      sizes={[90, 10]}
-      minSize={200}
-      style={{ flex: "1", height: "100%" }}
-    >
-      <Flex direction="column" height="100%">
-        <Flex
-          justifyContent="right"
-          alignItems="center"
-          padding="4pt 8pt"
-          gap="5px"
-          height="54px"
-          borderBottom="1px solid lightgray"
-          flex="0 0 54px"
+    <Flex direction="column" height="100%">
+      <Flex
+        justifyContent="right"
+        alignItems="center"
+        padding="4pt 8pt"
+        gap="5px"
+        height="54px"
+        borderBottom="1px solid lightgray"
+        flex="0 0 54px"
+      >
+        <HistoryToggle />
+        <QueryModeToggle />
+        <Spacer />
+        <QueryForm
+          defaultPrimaryKeys={primaryKeys}
+          onPrimaryKeysChange={setPrimaryKeys}
+        />
+        <Button
+          colorScheme="blue"
+          onClick={() => runQuery("query_diff")}
+          isDisabled={isPending}
+          size="sm"
+          leftIcon={<Icon as={VscDiff} />}
         >
-          <HistoryToggle />
-          <QueryModeToggle />
-          <Spacer />
-          <Button
-            colorScheme="blue"
-            onClick={() => runQuery("query_diff")}
-            isDisabled={isPending}
-            size="sm"
-            leftIcon={<Icon as={VscDiff} />}
-          >
-            Run Diff
-          </Button>
-        </Flex>
-
-        <Box width="100%" flex="1">
-          {isCustomQueries ? (
-            <DualSqlEditor
-              value={sqlQuery}
-              baseValue={baseSqlQuery}
-              onChange={setSqlQuery}
-              onChangeBase={setBaseSqlQuery}
-              onRun={() => runQuery("query")}
-              onRunBase={() => runQuery("query_base")}
-              onRunDiff={() => runQuery("query_diff")}
-            />
-          ) : (
-            <SqlEditor
-              value={sqlQuery}
-              onChange={setSqlQuery}
-              onRun={() => runQuery("query")}
-              onRunDiff={() => runQuery("query_diff")}
-            />
-          )}
-        </Box>
+          Run Diff
+        </Button>
       </Flex>
-      <QueryForm
-        p="5px"
-        border="1px"
-        borderColor="gray.300"
-        defaultPrimaryKeys={primaryKeys}
-        onPrimaryKeysChange={setPrimaryKeys}
-      />
-    </HSplit>
+
+      <Box width="100%" flex="1">
+        {isCustomQueries ? (
+          <DualSqlEditor
+            value={sqlQuery}
+            baseValue={baseSqlQuery}
+            onChange={setSqlQuery}
+            onChangeBase={setBaseSqlQuery}
+            onRun={() => runQuery("query")}
+            onRunBase={() => runQuery("query_base")}
+            onRunDiff={() => runQuery("query_diff")}
+          />
+        ) : (
+          <SqlEditor
+            value={sqlQuery}
+            onChange={setSqlQuery}
+            onRun={() => runQuery("query")}
+            onRunDiff={() => runQuery("query_diff")}
+          />
+        )}
+      </Box>
+    </Flex>
+    /* <QueryForm
+      p="5px"
+      border="1px"
+      borderColor="gray.300"
+      defaultPrimaryKeys={primaryKeys}
+      onPrimaryKeysChange={setPrimaryKeys}
+    /> */
   );
 };
diff --git a/js/src/components/query/SqlEditor.tsx b/js/src/components/query/SqlEditor.tsx
@@ -1,6 +1,19 @@
-import { Flex, Text, Stack, Badge, Spacer, IconButton } from "@chakra-ui/react";
+import {
+  Flex,
+  Text,
+  Stack,
+  Badge,
+  Spacer,
+  IconButton,
+  Button,
+  Icon,
+  Box,
+} from "@chakra-ui/react";
 import { EditorProps, DiffEditor, Editor } from "@monaco-editor/react";
 import { on } from "events";
+import { BiLogoXing } from "react-icons/bi";
+import { FaPlay } from "react-icons/fa6";
+import { RiPlayMiniFill } from "react-icons/ri";
 import { VscDebugStart } from "react-icons/vsc";
 
 interface SqlEditorProps {
@@ -39,26 +52,27 @@ const SqlEditor: React.FC<SqlEditorProps> = ({
     <>
       {(label || onRun || onRunBase) && (
         <Flex
-          backgroundColor="#E8EFF5"
-          height="18px"
-          fontSize={"12px"}
-          marginBottom={"6px"}
-          paddingX="2"
+          backgroundColor="#EDF2F880"
+          height="40px"
+          fontSize={"14px"}
+          align="center"
+          margin={"0"}
+          padding={"0px 16px"}
         >
           <Text as="b">{label ? label.toUpperCase() : ""}</Text>
           <Spacer />
           {(onRun || onRunBase) && (
-            <IconButton
-              borderRadius={"2px"}
-              aria-label="Run"
-              icon={<VscDebugStart />}
+            <Button
+              size="sm"
+              variant="outline"
               onClick={onRun || onRunBase}
-              color="green"
-              fontSize="18px"
-              size="18px"
-              marginX={2}
-              title={runButtonTitle}
-            />
+              backgroundColor={"white"}
+              // leftIcon={<Icon as={RiPlayMiniFill} />}
+              leftIcon={<Icon as={FaPlay} />}
+              padding={"6px 12px"}
+            >
+              Run Query
+            </Button>
           )}
         </Flex>
       )}
@@ -120,23 +134,29 @@ export const DualSqlEditor: React.FC<SqlEditorProps> = ({
 }: SqlEditorProps) => {
   return (
     <>
-      <Flex height={"100%"}>
-        <Stack height={"100%"} width={"50%"}>
+      <Flex height={"100%"} gap={0}>
+        <Stack
+          height={"100%"}
+          width={"50%"}
+          gap={0}
+          borderRight={"1px"}
+          borderColor={"#D4DBE4"}
+        >
           <SqlEditor
-            label="Current"
-            value={value}
-            onChange={onChange}
-            onRun={onRun}
+            label="Base"
+            value={baseValue || ""}
+            onChange={onChangeBase}
+            onRunBase={onRunBase}
             options={options}
             {...props}
           />
         </Stack>
-        <Stack height={"100%"} width={"50%"}>
+        <Stack height={"100%"} width={"50%"} gap={0}>
           <SqlEditor
-            label="Base"
-            value={baseValue || ""}
-            onChange={onChangeBase}
-            onRunBase={onRunBase}
+            label="Current"
+            value={value}
+            onChange={onChange}
+            onRun={onRun}
             options={options}
             {...props}
           />