Merge pull request #217 from DataRecce/feature/drc-268-bug-the-value-…

…diff-execute-is-not-enabled-if-the-default [Bug] Fix the default pk issue
DataRecce · Mar 7, 2024 · 6e51890 · 6e51890
2 parents b551f78 + 07a856d
commit 6e51890
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/js/src/components/valuediff/ValueDiffForm.tsx b/js/src/components/valuediff/ValueDiffForm.tsx
@@ -76,10 +76,20 @@ export function ValueDiffForm({
   );
 
   const model = params?.model;
+  const primaryKey = params?.primary_key;
   const node = _.find(lineageGraph.lineageGraphSets?.all.nodes, {
     name: params?.model,
   });
-  const primaryKey = params?.primary_key || node?.data.current?.primary_key;
+  const nodePrimaryKey = node?.data.current?.primary_key;
+
+  useEffect(() => {
+    if (!primaryKey && nodePrimaryKey) {
+      onParamsChanged({
+        ...params,
+        primary_key: nodePrimaryKey,
+      });
+    }
+  }, [primaryKey, nodePrimaryKey, params, onParamsChanged]);
 
   useEffect(() => {
     setIsReadyToExecute(primaryKey && model ? true : false);