Refine track event and props

Signed-off-by: Wei-Chun, Chang <[email protected]>
DataRecce · Dec 24, 2024 · e03c98d · e03c98d
1 parent 54922e7
commit e03c98d
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 6 deletions.
diff --git a/js/src/components/lineage/PreviewChangeView.tsx b/js/src/components/lineage/PreviewChangeView.tsx
@@ -96,7 +96,6 @@ function PreviewChangeTopBar({
             onRunResultOpen();
             runQuery();
             setTimeout(() => feedbackToast(), 3000);
-            trackPreviewChange({ action: "run", node: current?.name });
           }}
           colorScheme="blue"
           isLoading={isPending}
@@ -168,17 +167,39 @@ export function PreviewChangeView({
   };
   const { mutate: runQuery, isPending } = useMutation({
     mutationFn: queryFn,
+    onSuccess(data, variables) {
+      if (data.error) {
+        trackPreviewChange({
+          action: "run",
+          node: current?.name,
+          status: "failure",
+        });
+      } else {
+        trackPreviewChange({
+          action: "run",
+          node: current?.name,
+          status: "success",
+        });
+      }
+    },
   });
   const { feedbackToast, closeToast } = useFeedbackCollectionToast({
     feedbackId: localStorageKeys.previewChangeFeedbackID,
     description: "Enjoy preview change?",
+
     onFeedbackSubmit: (feedback: string) => {
       switch (feedback) {
         case "like":
-          trackPreviewChangeFeedback({ feedback: "like" });
+          trackPreviewChangeFeedback({ feedback: "like", node: current?.name });
           break;
         case "dislike":
-          trackPreviewChangeFeedback({ feedback: "dislike" });
+          trackPreviewChangeFeedback({
+            feedback: "dislike",
+            node: current?.name,
+          });
+          break;
+        case "link":
+          trackPreviewChangeFeedback({ feedback: "form", node: current?.name });
           break;
         default:
           console.log("Not support feedback type");
@@ -198,7 +219,7 @@ export function PreviewChangeView({
         onRunResultClose();
         clearRunResult();
         closeToast();
-        trackPreviewChange({ action: "close" });
+        trackPreviewChange({ action: "close", node: current?.name });
       }}
     >
       {/* <ModalOverlay /> */}

diff --git a/js/src/lib/api/track.ts b/js/src/lib/api/track.ts
@@ -43,14 +43,16 @@ export function trackHistoryAction(props: HistoryActionProps) {
 interface PreviewChangeProps {
   action: "explore" | "run" | "close";
   node?: string;
+  status?: "success" | "failure";
 }
 
 export function trackPreviewChange(props: PreviewChangeProps) {
   amplitude.track("[Experiment] preview_change", props);
 }
 
 interface PreviewChangeFeedbackProps {
-  feedback: "like" | "dislike";
+  feedback: "like" | "dislike" | "form";
+  node?: string;
 }
 
 export function trackPreviewChangeFeedback(props: PreviewChangeFeedbackProps) {

diff --git a/js/src/lib/hooks/useFeedbackCollectionToast.tsx b/js/src/lib/hooks/useFeedbackCollectionToast.tsx
@@ -14,12 +14,14 @@ function ReactionFeedback({
   description,
   onLike,
   onDislike,
+  onClickLink,
   externalLink,
   externalLinkText,
 }: {
   description: string;
   onLike: () => void;
   onDislike: () => void;
+  onClickLink: () => void;
   externalLink?: string;
   externalLinkText?: string;
 }) {
@@ -48,7 +50,12 @@ function ReactionFeedback({
         onClick={onDislike}
       />
       {externalLink && externalLinkText && (
-        <Link href={externalLink} isExternal textDecoration="underline">
+        <Link
+          href={externalLink}
+          isExternal
+          textDecoration="underline"
+          onClick={onClickLink}
+        >
           {externalLinkText}
         </Link>
       )}
@@ -113,6 +120,9 @@ export function useFeedbackCollectionToast(options: {
                 }}
                 externalLink={externalLink}
                 externalLinkText={externalLinkText}
+                onClickLink={() => {
+                  onFeedbackSubmit("link");
+                }}
               />
               <CloseButton onClick={onClose} />
             </HStack>