Rename showRunId callback function

Signed-off-by: Wei-Chun, Chang <[email protected]>
DataRecce · Oct 26, 2024 · e48a968 · e48a968
1 parent 11b2598
commit e48a968
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/js/src/components/lineage/LineageView.tsx b/js/src/components/lineage/LineageView.tsx
@@ -225,7 +225,7 @@ export function LineageView({ ...props }: LineageViewProps) {
     refetchRunsAggregated,
   } = useLineageGraphContext();
 
-  const { showRunId, closeRunResult } = useRecceActionContext();
+  const { showRunInfo, closeRunResult } = useRecceActionContext();
 
   /**
    * View mode
@@ -376,7 +376,7 @@ export function LineageView({ ...props }: LineageViewProps) {
       setNodes(selectSingleNode(node.id, nodes));
     } else if (selectMode === "action_result") {
       if (node.data.action?.run?.run_id) {
-        showRunId(node.data.action?.run?.run_id, node.data.action?.run?.type);
+        showRunInfo(node.data.action?.run?.run_id, node.data.action?.run?.type);
       }
       centerNode(node);
       setNodes(selectSingleNode(node.id, nodes));

diff --git a/js/src/components/lineage/NodeSelector.tsx b/js/src/components/lineage/NodeSelector.tsx
@@ -140,7 +140,7 @@ export function NodeSelector({
   });
   const queryClient = useQueryClient();
   const [, setLocation] = useLocation();
-  const { showRunId } = useRecceActionContext();
+  const { showRunInfo } = useRecceActionContext();
 
   const submitRunForNodes = async (
     type: RunType,
@@ -174,7 +174,7 @@ export function NodeSelector({
 
     try {
       const { run_id } = await submitRun(type, params, { nowait: true });
-      showRunId(run_id, type);
+      showRunInfo(run_id, type);
       actionState.currentRun = { run_id };
       actionState.total = 1;
 

diff --git a/js/src/components/query/QueryPage.tsx b/js/src/components/query/QueryPage.tsx
@@ -86,7 +86,7 @@ export const QueryPage = () => {
     sqlQuery = `select * from db.mymodel`;
   }
 
-  const { showRunId } = useRecceActionContext();
+  const { showRunInfo } = useRecceActionContext();
   const queryFn = async (type: "query" | "query_base" | "query_diff") => {
     function queryFactory(type: string) {
       switch (type) {
@@ -111,7 +111,7 @@ export const QueryPage = () => {
     }
     const { run_id } = await runFn(params, options);
 
-    showRunId(run_id, type);
+    showRunInfo(run_id, type);
 
     return await waitRun(run_id);
   };

diff --git a/js/src/components/run/RunList.tsx b/js/src/components/run/RunList.tsx
@@ -137,9 +137,9 @@ export const RunList = () => {
     },
     retry: false,
   });
-  const { showRunId, runId } = useRecceActionContext();
+  const { showRunInfo, runId } = useRecceActionContext();
   const handleSelectRun = (runId: string, runType: RunType) => {
-    showRunId(runId, runType, false);
+    showRunInfo(runId, runType, false);
   };
   const [, setLocation] = useLocation();
   const queryClient = useQueryClient();

diff --git a/js/src/lib/hooks/RecceActionContext.tsx b/js/src/lib/hooks/RecceActionContext.tsx
@@ -30,7 +30,7 @@ export interface RecceActionContextType {
   ) => void;
   runId?: string;
   runType?: RunType;
-  showRunId: (
+  showRunInfo: (
     runId: string,
     runType: RunType,
     refreshHistory?: boolean
@@ -44,7 +44,7 @@ export interface RecceActionContextType {
 
 export const RecceActionContext = createContext<RecceActionContextType>({
   runAction: () => {},
-  showRunId: (runId: string, runType: RunType) => {},
+  showRunInfo: (runId: string, runType: RunType) => {},
   isRunResultOpen: false,
   closeRunResult: () => {},
   isHistoryOpen: false,
@@ -99,7 +99,7 @@ export function RecceActionContextProvider({
   const [location, setLocation] = useLocation();
   const queryClient = useQueryClient();
 
-  const showRunId = useCallback(
+  const showRunInfo = useCallback(
     (runId: string, runType: RunType, refreshHistory?: boolean) => {
       setRunId(runId);
       setRunType(runType);
@@ -138,7 +138,7 @@ export function RecceActionContextProvider({
           const { run_id } = await submitRun(type, params, {
             nowait: true,
           });
-          showRunId(run_id, type);
+          showRunInfo(run_id, type);
           queryClient.invalidateQueries({ queryKey: cacheKeys.runs() });
           if (location.startsWith("/lineage")) {
             setLocation("/lineage");
@@ -169,7 +169,7 @@ export function RecceActionContextProvider({
     [
       setAction,
       onModalOpen,
-      showRunId,
+      showRunInfo,
       toast,
       location,
       setLocation,
@@ -184,7 +184,7 @@ export function RecceActionContextProvider({
       const { run_id } = await submitRun(type, params, {
         nowait: true,
       });
-      showRunId(run_id, type);
+      showRunInfo(run_id, type);
     } catch (e: any) {
       toast({
         title: "Failed to submit a run",
@@ -212,7 +212,7 @@ export function RecceActionContextProvider({
         runAction,
         runId,
         runType,
-        showRunId,
+        showRunInfo,
         isRunResultOpen,
         closeRunResult,
         isHistoryOpen,