Skip to content

Commit

Permalink
Merge pull request #289 from DataRecce/feature/drc-386-bug-the-value-…
Browse files Browse the repository at this point in the history
…diff-cannot-work-in-the-review-work

[Bug] The value diff is not working in the review mode.
  • Loading branch information
popcornylu authored Apr 23, 2024
2 parents c27b540 + a5541c2 commit f566e38
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/eslint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: Lint by ESLint

on:
push:
branches:
- main
paths:
- "js/**"
pull_request:
branches:
- main
paths:
- "js/**"

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: Run Python Flake8 and Unit Tests

on:
push:
branches:
- main
paths:
- "recce/**"
pull_request:
branches:
- main
paths:
- "recce/**"

Expand Down
2 changes: 2 additions & 0 deletions recce/adapter/dbt_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,8 @@ def import_artifacts(self, artifacts: ArtifactsRoot):
self.curr_manifest = load_manifest(data=artifacts.current.get('manifest'))
self.curr_catalog = load_catalog(data=artifacts.current.get('catalog'))

self.manifest = as_manifest(self.curr_manifest)

if not self.curr_manifest or not self.base_manifest:
raise Exception(
'No enough dbt artifacts in the state file. Please use the latest recce to generate the recce state')
Expand Down

0 comments on commit f566e38

Please sign in to comment.