Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] State file type validation rule #288

Conversation

wcchang1115
Copy link
Collaborator

@wcchang1115 wcchang1115 commented Apr 22, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Bug

What this PR does / why we need it:

  • In review mode, recce server would read state file and do basic type validation.

Which issue(s) this PR fixes:
DRC-387

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@wcchang1115 wcchang1115 marked this pull request as ready for review April 22, 2024 07:43
js/src/lib/api/info.ts Show resolved Hide resolved
@wcchang1115 wcchang1115 merged commit 5ab19bb into main Apr 25, 2024
3 checks passed
@wcchang1115 wcchang1115 deleted the feature/drc-387-bug-unable-to-get-review-to-work-need-help-checking-out-the branch April 25, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants