Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix failed to copy screenshots #291

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

wcchang1115
Copy link
Collaborator

@wcchang1115 wcchang1115 commented Apr 23, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Bug

What this PR does / why we need it:
fix compatibility issue of copying screenshot to the clipboard on different browsers.

  • wrong element transformation on the latest firefox
  • security limitation on safari

Which issue(s) this PR fixes:
DRC-385

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Wei-Chun, Chang <[email protected]>
Co-authored-by: Kent Huang <[email protected]>
Copy link

linear bot commented Apr 23, 2024

@wcchang1115 wcchang1115 marked this pull request as ready for review April 24, 2024 09:32
@wcchang1115 wcchang1115 merged commit b56b052 into main Apr 25, 2024
1 check passed
@wcchang1115 wcchang1115 deleted the feature/drc-385-bug-issues-for-copy-to-clipboard branch April 25, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants