Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] DRC-431 Fix recce summary wording #329

Merged

Conversation

kentwelcome
Copy link
Member

[Fix] remove typo

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Fix

What this PR does / why we need it:
Fix the wording of the result of recce summary based on the feedbacks from team members.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

linear bot commented May 17, 2024

Signed-off-by: Kent Huang <[email protected]>

[Fix] remove typo

Signed-off-by: Kent Huang <[email protected]>

fix typo

Signed-off-by: Kent Huang <[email protected]>
@kentwelcome kentwelcome force-pushed the feature/drc-431-fix-replace-failed-from-recce-summary branch from a934e2b to 7b636f2 Compare May 17, 2024 04:30
@kentwelcome
Copy link
Member Author

Output Example

Recce Summary

Lineage Graph

No changed module was detected.

Checks Summary

Checks Run Data Mismatch Detected Incomplete Checks
5 1 1

⚠️ Incomplete Checks refers to checks that did not successfully run due to configuration or SQL errors.
Please check the output of recce run for more information

Checks of Data Mismatch Detected

Name Type Related Models
Model schema of customers Schema Diff customers

@kentwelcome kentwelcome merged commit 1b873bb into main May 20, 2024
4 checks passed
@kentwelcome kentwelcome deleted the feature/drc-431-fix-replace-failed-from-recce-summary branch May 20, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant