Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The recce summary would raise exception if node is excluded #339

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

popcornylu
Copy link
Contributor

@popcornylu popcornylu commented Jun 12, 2024

Fix #336
Root cause
The node type 'snapshot' is not handled correctly.

Solution
When building the lineage graph object, dont put the the excluded node to the parent_map dict

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

linear bot commented Jun 12, 2024

@popcornylu popcornylu merged commit 1f2c62d into main Jun 12, 2024
3 checks passed
@popcornylu popcornylu deleted the feature/drc-490-bug-recce-summary-genarete-failed branch June 12, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DRC-490] [Bug] recce summary genarete failed
1 participant