Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] AttributeError: 'list' object has no attribute 'from_dict' #385

Conversation

popcornylu
Copy link
Contributor

@popcornylu popcornylu commented Jul 15, 2024

Reproducible Steps

If there is disabled model with test, the manifest would cotains .disable[<node_id>]. The value is a list rather than a dict, it would cause this issue.

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
#384

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

linear bot commented Jul 15, 2024

@popcornylu popcornylu force-pushed the feature/drc-561-bug-attributeerror-list-object-has-no-attribute-from_dict branch from 054e3fe to 4bb9011 Compare July 15, 2024 03:46
@popcornylu popcornylu changed the title Fix the node with disabled nodes Fix: [Bug] AttributeError: 'list' object has no attribute 'from_dict' Jul 15, 2024
@popcornylu popcornylu changed the title Fix: [Bug] AttributeError: 'list' object has no attribute 'from_dict' [Bug] AttributeError: 'list' object has no attribute 'from_dict' Jul 15, 2024
@popcornylu popcornylu merged commit 1b19b16 into main Jul 15, 2024
3 checks passed
@popcornylu popcornylu deleted the feature/drc-561-bug-attributeerror-list-object-has-no-attribute-from_dict branch July 15, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant