Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update the centering and fitting logic in the lineage view #451

Merged

Conversation

popcornylu
Copy link
Contributor

@popcornylu popcornylu commented Oct 14, 2024

  1. When clicking a node, center the node only when the side pane is not shown
  2. Center the selected node while resizing if one node is selected
  3. Fit the lineage graph while no node is selected.

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@popcornylu popcornylu merged commit 62827c2 into main Oct 16, 2024
3 checks passed
@popcornylu popcornylu deleted the feature/drc-777-dont-recenter-the-node-when-selecting-node branch October 16, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant