Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/drc 755 feature compare renamed columns #452

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Oct 14, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:
In this PR, we add a Custom Queries Mode switch when the user accesses the Query Page.
Once the Custom Queries Mode is enabled, the user can use separated queries to query base and current environment when executing the Run Diff.

CleanShot 2024-10-16 at 14 20 08@2x

In this way, the user can manually handle the rename columns case.

Which issue(s) this PR fixes:
#441

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- When user enable `Dual Mode` in the query page, they can use different
  queies for current & base environment

Signed-off-by: Kent Huang <[email protected]>
- Add keybinding for base run `Alt + Enter`
- Show correct SQL queries when the result is add to checklist

Signed-off-by: Kent Huang <[email protected]>
@kentwelcome kentwelcome marked this pull request as ready for review October 15, 2024 08:22
@kentwelcome kentwelcome merged commit 3c399da into main Oct 16, 2024
4 checks passed
@kentwelcome kentwelcome deleted the feature/drc-755-feature-compare-renamed-columns branch October 16, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant