Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-select checkbox on the node #486

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Add multi-select checkbox on the node #486

merged 15 commits into from
Nov 19, 2024

Conversation

popcornylu
Copy link
Contributor

@popcornylu popcornylu commented Nov 14, 2024 •
edited
Loading

  1. Change to use the checkbox to enter the multi-select mode
  2. Use the same action menu to run action on "single-selected" and "multi-selected" nodes.

image
image

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@popcornylu popcornylu force-pushed the feature/drc-894-enter-multi-nodes-mode-by-selecting-the-checkbox-of-a-node branch 4 times, most recently from e26a01a to ea6d3c5 Compare November 18, 2024 08:58
@popcornylu popcornylu marked this pull request as ready for review November 18, 2024 10:14
@popcornylu
Add multi-select checkbox on the node
d674e84 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Change the nodeselector flag hook to useDisclosure
a075d84 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Change to use hook to wrap the multi node action logic
e1a3cef 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Change to use hook to wrap the multi node action logic
ccd2e8d 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Change to use hook to wrap the multi node action logic
ae9df02 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Change to use hook to wrap the filter logic
9dfed5f 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Use action menu to run multi-nodes actions
e142c16 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Fix the select bug
7dd0ed8 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Add deselect and node count
32fa509 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Disable action item if not applicable
61d533a 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Dont highlight the parent child path if it is in multiselect mode
9cd71cb 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Rename the components
6ce3c2b 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Change the select mode values
d336bb3 
Signed-off-by: popcorny <[email protected]>
@popcornylu
Derive the selectedNode insteat of using useState
34417d0 
Signed-off-by: popcorny <[email protected]>
@popcornylu popcornylu force-pushed the feature/drc-894-enter-multi-nodes-mode-by-selecting-the-checkbox-of-a-node branch from 2e3d8d7 to 34417d0 Compare November 18, 2024 10:15
@popcornylu
Add action icons
a28892a 
Signed-off-by: popcorny <[email protected]>
@popcornylu popcornylu merged commit 9f9d4e9 into main Nov 19, 2024
4 checks passed
@popcornylu popcornylu deleted the feature/drc-894-enter-multi-nodes-mode-by-selecting-the-checkbox-of-a-node branch November 19, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@popcornylu