Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] DRC-879 Refine the UI of checklist page #489

Merged
merged 3 commits into from
Nov 18, 2024
Merged

[Feature] DRC-879 Refine the UI of checklist page #489

merged 3 commits into from
Nov 18, 2024

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • Make the checkbox clickable in the Check List View
  • Show the warring model if users check a check from the list view directly.
  • The warring model can be bypassed if you confirm it.
  • Show a toast when a Check is checked.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kentwelcome kentwelcome marked this pull request as ready for review November 18, 2024 09:51
@kentwelcome
[Fix] ESLint issue
2f079b3 
Signed-off-by: Kent Huang <[email protected]>
@kentwelcome
[Fix] Remove unused code
c113a7d 
Signed-off-by: Kent Huang <[email protected]>
@kentwelcome kentwelcome merged commit bc68d1a into main Nov 18, 2024
4 checks passed
@kentwelcome kentwelcome deleted the feature/drc-879-implement-the-checklist-ux-update branch November 18, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kentwelcome