Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix the schema check for no node selected state #494

Conversation

popcornylu
Copy link
Contributor

@popcornylu popcornylu commented Nov 19, 2024

Fix a regression bug from #493

The schema diff should not use the node_id if no node selected.

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@popcornylu popcornylu marked this pull request as ready for review November 19, 2024 09:58
@popcornylu popcornylu merged commit 65b3e96 into main Nov 19, 2024
4 checks passed
@popcornylu popcornylu deleted the feature/drc-911-support-to-use-single-schema-check-to-contains-all-mult branch November 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant