Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DRC-951 dbt run defer could make the server cannot launch #529

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Bugfix

What this PR does / why we need it:

  • Change to use get_lineage instead of get_model as the source to judge
    whether the schema diff has changed.
  • When the data source is Snowflake, get_model method will trigger the DB
    connection. In this case, we don't need to connect to DB. The manifest
    file already contains all the information we need.
  • Only recce run will trigger preset check pre-approved logic. This logic won't be invoked when launching the server.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ptesarik Petr Tesarik
- Change to use `get_lineage` instead of `get_model` as source to judge
  the schema diff is no changed or not.
- When the data source is Snowflake, `get_model` method will trigger DB
  connection. In this case, we don't need to connect to DB. Manifest
  file already contain all the information we need.

Signed-off-by: Kent Huang <[email protected]>
- Remove check preset check should be approved when launching server

Signed-off-by: Kent Huang <[email protected]>
Signed-off-by: Kent Huang <[email protected]>
recce/run.py Outdated Show resolved Hide resolved
Signed-off-by: Kent Huang <[email protected]>
…-the-server-cannot-launch
@kentwelcome kentwelcome merged commit 7680d97 into main Dec 11, 2024
6 checks passed
@kentwelcome kentwelcome deleted the feature/drc-951-bug-dbt-run-defer-could-make-the-server-cannot-launch branch December 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants