Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/drc 953 test case enhance unit test to prevent drc 935 wont be #537

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Infra

What this PR does / why we need it:

  • Add unittest for the function schema_diff_should_be_approved
  • Add unittest for RecceConfig

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
tests/tasks/test_schema.py 100.00% <100.00%> (ø)
tests/test_config.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@kentwelcome kentwelcome merged commit 39c44b7 into main Dec 16, 2024
7 checks passed
@kentwelcome kentwelcome deleted the feature/drc-953-test-case-enhance-unit-test-to-prevent-drc-935-wont-be branch December 16, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants