Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Upgrade npm packages #544

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Dec 18, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Security Patch

What this PR does / why we need it:

  • Upgrade npm packages to latest version
  • Rename react function names to fit the react naming rule
    • React component name should start with a capital letter
    • Replace _ with Private
  • Replace As with ElementType when calling ComponentWithAs

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Rename react function names to fit react naming rule
    - React component name should start with capital letter
    - Replace `_` by `Private`
- Replace As by ElementType when calling ComponentWithAs

Signed-off-by: Kent Huang <[email protected]>
@kentwelcome kentwelcome force-pushed the patch/npm_and_yarn/js/upgrade branch from 37e7c1a to cf8dad8 Compare December 18, 2024 04:26
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit a980bca into main Dec 18, 2024
6 checks passed
@kentwelcome kentwelcome deleted the patch/npm_and_yarn/js/upgrade branch December 18, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants