Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add smoke test for cloud mode #545

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

wcchang1115
Copy link
Collaborator

@wcchang1115 wcchang1115 commented Dec 18, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

  • Chore

What this PR does / why we need it:

  • Add smoke test for Recce cloud version
  • It's base on the example jaffle_shop_duckdb PR#41

Which issue(s) this PR fixes:
DRC-952

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@wcchang1115 wcchang1115 force-pushed the feature/drc-952-add-smoke-test-for-recce-cloud branch from d86f9b1 to 4e81228 Compare December 18, 2024 09:48
@wcchang1115 wcchang1115 marked this pull request as ready for review December 18, 2024 10:00
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussion, we change to use seperate workflow for cloud feature. But i think it is ok to test only the dbt version in the jaffle-shop-duckdb.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
recce/git.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
recce/git.py 44.06% <50.00%> (+1.96%) ⬆️

... and 10 files with indirect coverage changes

@wcchang1115 wcchang1115 force-pushed the feature/drc-952-add-smoke-test-for-recce-cloud branch from e07436a to dcd3eee Compare December 20, 2024 04:01
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcchang1115 wcchang1115 merged commit d2ee4e0 into main Dec 20, 2024
7 checks passed
@wcchang1115 wcchang1115 deleted the feature/drc-952-add-smoke-test-for-recce-cloud branch December 20, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants