Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] DRC-980 Show tooltip on node selector input field #561

Merged

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Dec 27, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • Add Tooltip on node selector input field
    CleanShot 2024-12-27 at 16 56 10
  • This tooltip will only shown under the single environment mode

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kentwelcome kentwelcome force-pushed the feature/drc-980-hint-users-to-use-selector-in-all-models-mode branch from fd04943 to b09d1ab Compare December 30, 2024 06:56
@kentwelcome kentwelcome marked this pull request as ready for review December 30, 2024 07:03
Copy link
Collaborator

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the zindex of the tooltip may need to be adjusted.

@kentwelcome
Copy link
Member Author

As discussed, the zindex of the tooltip may need to be adjusted.

Reconfigure the zIndex of the selector tooltip as "dropdown". It will be overwritten by the popup modal.

CleanShot 2024-12-30 at 17 11 50

Copy link
Collaborator

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kentwelcome kentwelcome merged commit 7fcadea into main Dec 30, 2024
8 checks passed
@kentwelcome kentwelcome deleted the feature/drc-980-hint-users-to-use-selector-in-all-models-mode branch December 30, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants