[Feature] Guide users to download artifacts to target base #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feature/drc-982-onboarding-guide-when-recce-server-launched-with-single
to
main
December 30, 2024 06:44
|
This guide is for Experiment 2, the production environment setup guide should only be shown when |
kentwelcome
requested changes
Dec 30, 2024
| onClick={() => feedbackToast(true)} | ||
| onClick={() => { | ||
| feedbackToast(true); | ||
| prepareEnvToast(true); |
There was a problem hiding this comment.
Show both feedback and prepare env toast when the user clicksthe feedback button seems weird.
Give us feedback button should only show a feedback toast.
There was a problem hiding this comment.
ok, I will remove it.
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
wcchang1115
force-pushed
the
feature/drc-983-guide-users-to-download-artifacts-to-target-base
branch
from
5bb4be3 to
e249fac
Compare
wcchang1115
deleted the
feature/drc-983-guide-users-to-download-artifacts-to-target-base
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
DRC-983
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE