Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] DRC-986 Telemetry for single environment experiment #568

Merged

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Jan 3, 2025

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:
New event type [Experiment] single_environment

  • CLI launch server -> { action: "launch_server"}
  • Single environment popup confirmed by user -> {action: "onboarding"}
  • User click the external link -> `{action: "external_link", from: "onboarding|preview_changes"}
  • Click preview changes button -> {action: "preview_changes"}
  • Dected target-base added -> {action: "target_base_added"}

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
recce/event/__init__.py 40.00% 3 Missing ⚠️
recce/server.py 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
recce/server.py 52.45% <33.33%> (-0.18%) ⬇️
recce/event/__init__.py 63.00% <40.00%> (-1.50%) ⬇️

... and 5 files with indirect coverage changes

- Change to use schedule_flush instead of send_events

Signed-off-by: Kent Huang <[email protected]>
Co-authored-by: Wei-Chun, Chang <[email protected]>
Copy link
Collaborator

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@kentwelcome kentwelcome merged commit baa3b50 into main Jan 3, 2025
11 checks passed
@kentwelcome kentwelcome deleted the feature/drc-986-telemetry-for-single-environment-experiment branch January 3, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants