Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Overwrite response 304 when etag not match #576

Closed

Conversation

wcchang1115
Copy link
Collaborator

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • Instead of disable cache with no-store, we overwrite the 304 response when the etag is not matched.

Which issue(s) this PR fixes:
DRC-995

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
recce/server.py 0.00% 9 Missing ⚠️
Files with missing lines Coverage Δ
recce/server.py 51.11% <0.00%> (-1.35%) ⬇️

... and 6 files with indirect coverage changes

@wcchang1115 wcchang1115 marked this pull request as ready for review January 10, 2025 07:20
@wcchang1115
Copy link
Collaborator Author

After discussion, we prefer not to overwrite the cache behavior.
Just use no-store to disable cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant