Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: update instructions for Windows #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ocombe
Copy link

@ocombe ocombe commented Feb 6, 2024

Hello ! Installing Wrangler on Windows only works if Perl has been installed (should be installed by default on Unix systems).
I added a link to a working Windows Perl distribution in the readme.

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 6, 2024

I am not aware of a component which needs Perl, can you tell me what failed for you without Perl, so I can see if we just cant get rid of that all together?

@ocombe
Copy link
Author

ocombe commented Feb 6, 2024

It is required for wrangler, you cannot run cargo install wrangler without perl, it fails during compilation

More info: sfackler/rust-openssl#1086 (comment)

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 6, 2024

Thanks, that's annoying.

Btw that reminds me you might have to install worker-build from my fork, if you encounter some bundling errors. Not sure if they ever fixed the bug I had with the assets manifest.

@ocombe
Copy link
Author

ocombe commented Feb 6, 2024

I didn't go that far yet, I tried yarn start and it fails already :D
I'll look into it later

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 11, 2024

@ocombe did you figure out the issues? I think you'd definitely have to use WSL, the setup is very fragile and held together with a bash script, which is probably the issue.

@ocombe
Copy link
Author

ocombe commented Feb 12, 2024

I didn't retry, like you said the scripts won't work on windows. I just wanted to check the sources (especially the part used to create the passive skill tree), so for now it doesn't really matter

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 12, 2024

The skilltree is in poe-tmm.

I recently reworked this, it used to be a service which generated SVGs on the fly, now it's just a single SVG per game version with embedded JS. If you're interested in the service you can go a few commits back.

@Dav1dde Dav1dde force-pushed the master branch 5 times, most recently from 6afbd76 to 66dc0e2 Compare May 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants