Skip to content

Commit

Permalink
fix warning message when editing and R >= 4.2.0
Browse files Browse the repository at this point in the history
issue #36
  • Loading branch information
DavidPatShuiFong committed Nov 1, 2022
1 parent 8603b11 commit 4e35079
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 23 deletions.
42 changes: 21 additions & 21 deletions DTedit.Rproj
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
Version: 1.0
RestoreWorkspace: Default
SaveWorkspace: Default
AlwaysSaveHistory: Default
EnableCodeIndexing: Yes
UseSpacesForTab: Yes
NumSpacesForTab: 2
Encoding: UTF-8
RnwWeave: Sweave
LaTeX: pdfLaTeX
AutoAppendNewline: Yes
StripTrailingWhitespace: Yes
BuildType: Package
PackageUseDevtools: Yes
PackageInstallArgs: --no-multiarch --with-keep.source --install-tests
PackageRoxygenize: rd,collate,namespace
Version: 1.0

RestoreWorkspace: Default
SaveWorkspace: Default
AlwaysSaveHistory: Default

EnableCodeIndexing: Yes
UseSpacesForTab: Yes
NumSpacesForTab: 2
Encoding: UTF-8

RnwWeave: Sweave
LaTeX: pdfLaTeX

AutoAppendNewline: Yes
StripTrailingWhitespace: Yes

BuildType: Package
PackageUseDevtools: Yes
PackageInstallArgs: --no-multiarch --with-keep.source --install-tests
PackageRoxygenize: rd,collate,namespace
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ output: html_document
---

## DTedit 2.3.2
13th November 2021
1st November 2022

### Bugfix

* Better handling of tibbles. Convert to data.frame as soon as possible.
* Avoid warning message when editing row (issue #36), thanks @andresrcs
- fixed incorrect handling of options for selectize input-type variants

## DTedit 2.3.1
22nd October 2021
Expand Down
2 changes: 1 addition & 1 deletion R/dtedit.R
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ dteditmod <- function(input, output, session,
#
# returns a list of shiny inputs, 'fields'

if (grepl("selectize", inputTypes) && !is.null(selectize.options)) {
if (any(grepl("selectize", inputTypes)) && !is.null(selectize.options)) {
# if *any* of the selectize input-type variants in the inputTypes
# and selectize.options is actually defined
#
Expand Down

0 comments on commit 4e35079

Please sign in to comment.