Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outputRootPath when outputRootPath is null and on player #124

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix outputRootPath when outputRootPath is null and on player #124

merged 1 commit into from
Dec 2, 2024

Conversation

nowsprinting
Copy link
Contributor

Fixes

  • Fix OutputRootPath when outputRootPath is null and on player
  • Add tests

Priority

Low

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 30, 2024 01:49
@github-actions github-actions bot added the fix label Nov 30, 2024
@nowsprinting nowsprinting changed the title Fix `utputRootPath when outputRootPath is null and on player Fix outputRootPath when outputRootPath is null and on player Nov 30, 2024
bo40
bo40 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit 9bf75d1 into DeNA:master Dec 2, 2024
2 checks passed
@nowsprinting nowsprinting deleted the fix/output_root_path branch December 2, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @bo40