Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting item labels of SlackReporter #132

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix setting item labels of SlackReporter #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1ea5e5
Fix s/sub team/user group/
nowsprinting Dec 22, 2024
2b79872
Fix s/Slack API token/Slack Bot OAuth token/
nowsprinting Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Editor/Localization/ja.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,8 +560,8 @@ msgid "Slack Token"
msgstr "Slackトークン"

# slackToken tooltip
msgid "Slack API token. If omitted, it will not be sent."
msgstr "Slack通知に使用するWeb APIトークン（省略時は送信されません）"
msgid "Slack Bot OAuth token. If omitted, it will not be sent."
msgstr "Slack通知に使用するBotのOAuthトークン（省略時は送信されません）"

# slackChannels
msgid "Slack Channels"
Expand All @@ -576,12 +576,12 @@ msgid "Error Report Settings"
msgstr "エラーレポート設定"

# mentionSubTeamIDs
msgid "Mention Sub Team IDs"
msgstr "メンション宛先チームID"
msgid "Mention user group IDs"
msgstr "メンション宛先ユーザーグループID"

# mentionSubTeamIDs tooltip
msgid "Comma-separated sub team IDs to mention when posting error reports."
msgstr "エラー終了時に送信する通知をメンションするチームのIDをカンマ区切りで指定します"
msgid "Comma-separated user group IDs to mention when posting error reports."
msgstr "エラー終了時に送信する通知をメンションするユーザーグループのIDをカンマ区切りで指定します"

# addHereInSlackMessage
msgid "Add @here"
Expand Down Expand Up @@ -636,12 +636,12 @@ msgid "Also post a report if completed autopilot normally."
msgstr "正常終了時にもレポートを送信します"

# mentionSubTeamIDs (same as mentionSubTeamIDsOnError)
msgid "Mention Sub Team IDs"
msgstr "メンション宛先チームID"
msgid "Mention User Group IDs"
msgstr "メンション宛先ユーザーグループID"

# mentionSubTeamIDs tooltip
msgid "Comma-separated sub team IDs to mention when posting completion reports."
msgstr "正常終了時に送信する通知をメンションするチームのIDをカンマ区切りで指定します"
msgid "Comma-separated user group IDs to mention when posting completion reports."
msgstr "正常終了時に送信する通知をメンションするユーザーグループのIDをカンマ区切りで指定します"

# addHereInSlackMessage (same as addHereInSlackMessageOnError)
msgid "Add @here"
Expand Down
10 changes: 5 additions & 5 deletions Editor/UI/Reporters/SlackReporterEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class SlackReporterEditor : UnityEditor.Editor
private GUIContent _descriptionGUIContent;

private static readonly string s_slackToken = L10n.Tr("Slack Token");
private static readonly string s_slackTokenTooltip = L10n.Tr("Slack API token. If omitted, it will not be sent.");
private static readonly string s_slackTokenTooltip = L10n.Tr("Slack Bot OAuth token. If omitted, it will not be sent.");
private SerializedProperty _slackTokenProp;
private GUIContent _slackTokenGUIContent;

Expand All @@ -35,8 +35,8 @@ public class SlackReporterEditor : UnityEditor.Editor

private static readonly string s_errorSettingsHeader = L10n.Tr("Error Report Settings");

private static readonly string s_mentionSubTeamIDs = L10n.Tr("Mention Sub Team IDs");
private static readonly string s_mentionSubTeamIDsTooltip = L10n.Tr("Comma-separated sub team IDs to mention when posting error reports.");
private static readonly string s_mentionSubTeamIDs = L10n.Tr("Mention User Group IDs");
private static readonly string s_mentionSubTeamIDsTooltip = L10n.Tr("Comma-separated user group IDs to mention when posting error reports.");
private SerializedProperty _mentionSubTeamIDsProp;
private GUIContent _mentionSubTeamIDsGUIContent;

Expand Down Expand Up @@ -72,8 +72,8 @@ public class SlackReporterEditor : UnityEditor.Editor
private SerializedProperty _postOnNormallyProp;
private GUIContent _postOnNormallyGUIContent;

private static readonly string s_mentionSubTeamIDsOnNormally = L10n.Tr("Mention Sub Team IDs");
private static readonly string s_mentionSubTeamIDsOnNormallyTooltip = L10n.Tr("Comma-separated sub team IDs to mention when posting completion reports.");
private static readonly string s_mentionSubTeamIDsOnNormally = L10n.Tr("Mention User Group IDs");
private static readonly string s_mentionSubTeamIDsOnNormallyTooltip = L10n.Tr("Comma-separated user group IDs to mention when posting completion reports.");
private SerializedProperty _mentionSubTeamIDsOnNormallyProp;
private GUIContent _mentionSubTeamIDsOnNormallyGUIContent;

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ The instance of this Reporter (.asset file) can have the following settings.
<dt>Slack Channels</dt><dd>Channels to send notifications. If omitted, not notified. Multiple channels can be specified by separating them with commas.
Note that the bot must be invited to the channel.
It can be overwritten with the command line argument <code>-SLACK_CHANNELS</code>, but be careful if multiple SlackReporters are defined, they will all be overwritten with the same value.</dd>
<dt>Mention Sub Team IDs</dt><dd>Comma-separated sub team IDs to mention when posting error reports.</dd>
<dt>Mention User Group IDs</dt><dd>Comma-separated user group IDs to mention when posting error reports.</dd>
<dt>Add @here</dt><dd>Add @here to the post when posting error reports.</dd>
<dt>Lead Text</dt><dd>Lead text for error reports. It is used in OS notifications. You can specify placeholders like a "{message}".</dd>
<dt>Message</dt><dd>Message body template for error reports. You can specify placeholders like a "{message}".</dd>
Expand Down
2 changes: 1 addition & 1 deletion README_ja.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ Slackにレポート送信するReporterです。
<dt>Slackチャンネル</dt><dd>通知を送るチャンネル（省略時は通知されない）。カンマ区切りで複数指定できます。
なお、チャンネルにはBotを招待しておく必要があります。
コマンドライン引数 <code>-SLACK_CHANNELS</code> で上書きできますが、複数のSlackReporterを定義しているとき、すべて同じ値で上書きされますので注意してください。</dd>
<dt>メンション宛先チームID</dt><dd>エラー終了時に送信する通知をメンションするチームのIDをカンマ区切りで指定します</dd>
<dt>メンション宛先ユーザーグループID</dt><dd>エラー終了時に送信する通知をメンションするユーザーグループのIDをカンマ区切りで指定します</dd>
<dt>@hereをつける</dt><dd>エラー終了時に送信する通知に@hereを付けます</dd>
<dt>リード文</dt><dd>エラー終了時に送信する通知のリード文。OSの通知に使用されます。"{message}" のようなプレースホルダーを指定できます</dd>
<dt>メッセージ</dt><dd>エラー終了時に送信するメッセージ本文のテンプレート。"{message}" のようなプレースホルダーを指定できます</dd>
Expand Down
6 changes: 3 additions & 3 deletions Runtime/Reporters/SlackReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace DeNA.Anjin.Reporters
public class SlackReporter : AbstractReporter
{
/// <summary>
/// Slack API token.
/// Slack Bot OAuth token.
/// </summary>
public string slackToken;

Expand All @@ -26,7 +26,7 @@ public class SlackReporter : AbstractReporter
public string slackChannels;

/// <summary>
/// Comma-separated sub team IDs to mention when posting error reports.
/// Comma-separated user group IDs to mention when posting error reports.
/// </summary>
public string mentionSubTeamIDs;

Expand Down Expand Up @@ -63,7 +63,7 @@ public class SlackReporter : AbstractReporter
public bool postOnNormally;

/// <summary>
/// Comma-separated sub team IDs to mention when posting completion reports.
/// Comma-separated user group IDs to mention when posting completion reports.
/// </summary>
public string mentionSubTeamIDsOnNormally;

Expand Down
Loading