Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CancellationToken parameter/variable name #136

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Rename CancellationToken parameter/variable name #136

merged 2 commits into from
Jan 10, 2025

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Rename CancellationToken parameter/variable name from token to cancellationToken
  • Fix log message (not use 三点リーダー)

Priority

Very low

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner January 4, 2025 22:24
@github-actions github-actions bot added the chore label Jan 4, 2025
asurato
asurato approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit d0ac012 into DeNA:master Jan 10, 2025
2 checks passed
@nowsprinting nowsprinting deleted the chore/cancellationtoken branch January 10, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asurato asurato asurato approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @asurato