Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lcm alignment #9

Closed
wants to merge 1 commit into from
Closed

Fix lcm alignment #9

wants to merge 1 commit into from

Conversation

TheoWinterhalter
Copy link
Contributor

Fixes an issue in #6 with lcm that was using Z.div instead of Zdiv. Fortunately they agree when the denominator is positive which is the case here.

@TheoWinterhalter TheoWinterhalter mentioned this pull request Feb 18, 2025
Merged
@fblanqui
Copy link
Member

Thanks Théo! I included your patch in #8 .

@fblanqui fblanqui closed this Feb 18, 2025
@TheoWinterhalter
Copy link
Contributor Author

For proper attribution you can use commit co-authoring by adding

Co-authored-by: NAME <[email protected]>

in the commit message. Like I did for @NotBad4U.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheoWinterhalter @fblanqui