Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/translate: Add model_type and model_type_used parameters #25

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

daniel-jones-dev
Copy link
Member

@daniel-jones-dev daniel-jones-dev commented Nov 15, 2024

Also bumps the minor version as this is a new feature.

Also I removed mention of the 50 max items for text translation -- there is no limit.

@JanEbbing
Copy link
Member

LGTM. What is the openapi_gitbook.yaml file?

@daniel-jones-dev
Copy link
Member Author

LGTM. What is the openapi_gitbook.yaml file?

It's linked directly from our GitBook documentation, and has simplified descriptions.

@JanEbbing JanEbbing self-requested a review November 15, 2024 16:19
Copy link
Member

@mike-winters-deepl mike-winters-deepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @daniel-jones-dev!

@daniel-jones-dev daniel-jones-dev merged commit 4ef5c12 into main Nov 15, 2024
1 check passed
@daniel-jones-dev daniel-jones-dev deleted the add-model-type branch November 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants